-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(payments_v2): implement payments capture v2 #6722
Open
Narayanbhat166
wants to merge
13
commits into
main
Choose a base branch
from
payments_capture_v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperswitch-bot
bot
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Dec 2, 2024
jarnura
previously approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR introduces payments capture endpoint for the v2 version.
This PR also changes the
GenerateResponse
trait to be implemented on the payment data. The new trait looks like thisAlso the fields in
AttemptAmountDetails
are made as private, necessary getters and setters are provided to work with these fields.Resolved some of the clippy warnings for v2.
Motivation and Context
How did you test it?
Create a payment with automatic capture
Confirm the payment intent
amount_capturable
should be 0 indicating that no amount can be captured further.amount_captured
should be equal to the net amount.Create a payment with manual capture
Confirm the payment intent
requires_capture
, withamount_capturable
equal to the net amountCapture the payment
Create a 3DS payment
Complete the redirection
Retrieve the payment
Create a partial capture
amount_to_capture
partially_captured
Checklist
cargo +nightly fmt --all
cargo clippy