Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Unifiedauthenticationservice] add Connector Template Code #6732

Merged
merged 3 commits into from
Dec 10, 2024
Merged

feat(connector): [Unifiedauthenticationservice] add Connector Template Code #6732

merged 3 commits into from
Dec 10, 2024

Conversation

sumanmaji4
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

template for unified_authentication_service

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sumanmaji4 sumanmaji4 self-assigned this Dec 3, 2024
@sumanmaji4 sumanmaji4 requested review from a team as code owners December 3, 2024 12:50
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Dec 3, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector.rs  79% smaller
  crates/hyperswitch_connectors/src/connectors.rs  67% smaller
  config/config.example.toml Unsupported file format
  config/deployments/integration_test.toml Unsupported file format
  config/deployments/production.toml Unsupported file format
  config/deployments/sandbox.toml Unsupported file format
  config/development.toml Unsupported file format
  config/docker_compose.toml Unsupported file format
  crates/api_models/src/connector_enums.rs  0% smaller
  crates/common_enums/src/connector_enums.rs  0% smaller
  crates/hyperswitch_connectors/src/connectors/unified_authentication_service.rs  0% smaller
  crates/hyperswitch_connectors/src/connectors/unified_authentication_service/transformers.rs  0% smaller
  crates/hyperswitch_connectors/src/default_implementations.rs  0% smaller
  crates/hyperswitch_connectors/src/default_implementations_v2.rs  0% smaller
  crates/hyperswitch_interfaces/src/configs.rs  0% smaller
  crates/router/src/core/payments/connector_integration_v2_impls.rs  0% smaller
  crates/router/src/core/payments/flows.rs  0% smaller
  crates/router/src/types/api.rs  0% smaller
  crates/router/src/types/transformers.rs  0% smaller
  crates/router/tests/connectors/main.rs  0% smaller
  crates/router/tests/connectors/sample_auth.toml Unsupported file format
  crates/router/tests/connectors/unified_authentication_service.rs  0% smaller
  crates/test_utils/src/connector_auth.rs  0% smaller
  loadtest/config/development.toml Unsupported file format
  scripts/add_connector.sh Unsupported file format

@sumanmaji4 sumanmaji4 changed the title unifiedauthenticationservice template feat(connector): [Unifiedauthenticationservice] add Connector Template Code Dec 3, 2024
deepanshu-iiitu
deepanshu-iiitu requested changes Dec 3, 2024
View reviewed changes
crates/hyperswitch_connectors/src/default_implementations_v2.rs Outdated
@@ -243,6 +243,7 @@ default_imp_for_new_connector_integration_payment!(
connectors::Thunes,
connectors::Tsys,
connectors::Worldline,
connectors::Unifiedauthenticationservice,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please maintain alphabetical order

deepanshu-iiitu
deepanshu-iiitu previously approved these changes Dec 3, 2024
View reviewed changes
sahkal
sahkal previously approved these changes Dec 3, 2024
View reviewed changes
SanchithHegde
SanchithHegde reviewed Dec 3, 2024
View reviewed changes
config/config.example.toml Outdated
@@ -267,6 +267,7 @@ stripe.base_url_file_upload = "https://files.stripe.com/"
trustpay.base_url = "https://test-tpgw.trustpay.eu/"
trustpay.base_url_bank_redirects = "https://aapi.trustpay.eu/"
tsys.base_url = "https://stagegw.transnox.com/"
unifiedauthenticationservice.base_url = "https://uas.internal.staging.mum.juspay.net"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have this as snake case please? Becomes difficult to read when the names get longer.

crates/api_models/src/connector_enums.rs Outdated
@@ -123,6 +123,7 @@ pub enum Connector {
//Thunes,
Trustpay,
Tsys,
// Unifiedauthenticationservice,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have this as UnifiedAuthenticationService so that the snake_case value used would be unified_authentication_service?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @sumanmaji4 can you make this change!

@sumanmaji4 sumanmaji4 dismissed stale reviews from sahkal and deepanshu-iiitu via 88347bd December 3, 2024 15:58
sahkal
sahkal previously approved these changes Dec 4, 2024
View reviewed changes
@sahkal sahkal self-requested a review December 4, 2024 07:08
SanchithHegde
SanchithHegde previously approved these changes Dec 4, 2024
View reviewed changes
sahkal
sahkal previously approved these changes Dec 4, 2024
View reviewed changes
deepanshu-iiitu
deepanshu-iiitu previously approved these changes Dec 4, 2024
View reviewed changes
@likhinbopanna likhinbopanna added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 4, 2024
@SanchithHegde SanchithHegde added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 4, 2024
@sumanmaji4 sumanmaji4 added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels Dec 5, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Dec 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 5, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 8777f41 Dec 10, 2024
18 checks passed
@likhinbopanna likhinbopanna deleted the add-uas-test branch December 10, 2024 11:03
kashif-m pushed a commit that referenced this pull request Dec 12, 2024
@sumanmaji4 @hyperswitch-bot @kashif-m
feat(connector): [Unifiedauthenticationservice] add Connector Templat…
af5d97e 
…e Code (#6732)

Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

@sahkal sahkal sahkal approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@sumanmaji4 sumanmaji4

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sumanmaji4 @SanchithHegde @sahkal @deepanshu-iiitu @likhinbopanna