Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dynamic_routing): integration of elimination routing for core flows #6816

Open
wants to merge 57 commits into
base: main
Choose a base branch
from
Open

feat(dynamic_routing): integration of elimination routing for core flows #6816

wants to merge 57 commits into from
+462 −129

Conversation

prajjwalkumar17
Copy link
Contributor

@prajjwalkumar17 prajjwalkumar17 commented Dec 12, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This will integrate elimination routing in our core flows for connectors to be filtered on basis of error codes received.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

Aprabhat19 and others added 18 commits November 27, 2024 12:52
@Aprabhat19
build theinterface for elimination routing
7b21417 
:
@Aprabhat19
resolve conflicts
5598cb0
@Aprabhat19
resolve conflicts add invalidation window
096bdf8
@hyperswitch-bot
chore: run formatter
537c59a
@Aprabhat19
rename files
b91d640
@Aprabhat19 @Chethan-rao
Update crates/external_services/src/grpc_client/dynamic_routing.rs
03ab2fb 
Co-authored-by: Chethan Rao <[email protected]>
@Aprabhat19
resolved conflict
0048389
@Aprabhat19
Merge branch 'main' of https://github.com/juspay/hyperswitch into eli…
477abe3 
…mination-routing-interface
@hyperswitch-bot
chore: run formatter
a4b61ca
@Aprabhat19
resolve conflicts
3199e57
@Aprabhat19
Merge branch 'elimination-routing-interface' of https://github.com/ju…
ef3c26e 
…spay/hyperswitch into elimination-routing-interface
@Aprabhat19
add external fields
7488944
@Aprabhat19
change the value types
0353013
@Aprabhat19
minor changes
2003e6c
@Aprabhat19
proto update
a06e7c8
@Aprabhat19
Merge branch 'main' of https://github.com/juspay/hyperswitch into eli…
a5f8a00 
…mination-routing-interface
@Aprabhat19
address naming changes
651973c
@prajjwalkumar17
init for er in core
6388c20
@prajjwalkumar17 prajjwalkumar17 requested review from a team as code owners December 12, 2024 04:52
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Dec 12, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/payments/operations/payment_response.rs  89% smaller
  crates/api_models/src/routing.rs  17% smaller
  crates/router/src/core/payments/routing.rs  1% smaller
  crates/router/src/core/routing/helpers.rs  1% smaller
  config/development.toml Unsupported file format
  crates/common_enums/src/enums.rs  0% smaller
  crates/router/Cargo.toml Unsupported file format
  crates/router/src/core/errors.rs  0% smaller

@prajjwalkumar17 prajjwalkumar17 marked this pull request as draft December 12, 2024 04:52
@prajjwalkumar17 prajjwalkumar17 self-assigned this Dec 12, 2024
@prajjwalkumar17 prajjwalkumar17 changed the base branch from main to elimination-routing-interface December 12, 2024 08:21
@prajjwalkumar17 prajjwalkumar17 changed the base branch from elimination-routing-interface to main December 12, 2024 08:22
@SanchithHegde SanchithHegde added this to the January 2025 Release milestone Jan 19, 2025
Chethan-rao
Chethan-rao requested changes Jan 20, 2025
View reviewed changes
NishantJoshi00
NishantJoshi00 previously approved these changes Jan 27, 2025
View reviewed changes
Base automatically changed from update_proto_for_er to main January 29, 2025 08:22
@likhinbopanna likhinbopanna dismissed NishantJoshi00’s stale review January 29, 2025 08:22

The base branch was changed.

@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner January 29, 2025 08:22
@prajjwalkumar17 prajjwalkumar17 changed the base branch from main to contracts-dr-router-integration February 3, 2025 08:43
@prajjwalkumar17 prajjwalkumar17 changed the base branch from contracts-dr-router-integration to main February 5, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chethan-rao Chethan-rao Awaiting requested review from Chethan-rao

@NishantJoshi00 NishantJoshi00 Awaiting requested review from NishantJoshi00

@Sarthak1799 Sarthak1799 Awaiting requested review from Sarthak1799

Requested changes must be addressed to merge this pull request.

Assignees

@prajjwalkumar17 prajjwalkumar17

Labels
A-euclid-foc Area: Euclid Family of Crates C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
February 2025 Release
Development

Successfully merging this pull request may close these issues.

Integration of ER in core flow
6 participants
@prajjwalkumar17 @NishantJoshi00 @Chethan-rao @Sarthak1799 @SanchithHegde @Aprabhat19