Serving PWA-related files #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. The changes you've made are necessary if you plan to use Django to host your frontend files. From the discussion in the YouTube video I can see that merging this makes sense however, I believe it's better to deploy the frontend as a static site and deploy the Django app as a standalone API. That way you won't need to specify these settings in your Django app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've come to believe that these changes are neccesary in order to properly serve these PWA-related files (namely, favicon.ico, manifest.json, and the build-generated service-worker.json, precache-manifest(...).js and asset-manifest.json.
If you reject this because there's a better way or I'm misinterpreting something (I'm pretty new to SW and PWA) please advise on how to proceed.
Thanks!