[email protected]: rating fixed point value (#2460)

* Update: rating fixed point value * Update: fixed tests * Update: update review number * Update: improve tests
justeattakeaway · Mar 26, 2024 · d6c2f5c · d6c2f5c
1 parent c905adf
commit d6c2f5c
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 14 deletions.
diff --git a/packages/components/molecules/f-restaurant-card/CHANGELOG.md b/packages/components/molecules/f-restaurant-card/CHANGELOG.md
@@ -3,6 +3,14 @@
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+v1.6.1
+
+_March 25, 2024_
+
+### Changed
+- Update fixed point value of restaurant rating from 2 to 1
+- Update max number of reviews
+
 ## v1.6.0
 
 _March 13, 2024_

diff --git a/packages/components/molecules/f-restaurant-card/package.json b/packages/components/molecules/f-restaurant-card/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@justeat/f-restaurant-card",
   "description": "Fozzie Restaurant Card -  Responsible for displaying restaurant data and linking to a restaurant",
-  "version": "1.6.0",
+  "version": "1.6.1",
   "main": "dist/f-restaurant-card.umd.min.js",
   "files": [
     "dist",

diff --git a/...ules/f-restaurant-card/src/components/subcomponents/RestaurantRating/RestaurantRating.vue b/...ules/f-restaurant-card/src/components/subcomponents/RestaurantRating/RestaurantRating.vue
@@ -77,8 +77,8 @@
                 <data
                     data-test-id="rating"
                     :class="[$style['c-restaurantCard-rating-count']]"
-                    :value="count">
-                    {{ count }}
+                    :value="formattedCount">
+                    {{ formattedCount }}
                 </data>
                 &#41;
             </span>
@@ -158,7 +158,10 @@ export default {
             return !this.mean;
         },
         meanFormatted () {
-            return Number.parseFloat(this.mean).toFixed(2);
+            return Number.parseFloat(this.mean).toFixed(1);
+        },
+        formattedCount () {
+            return this.count > 200 ? '200+' : this.count;
         }
     }
 };

diff --git a/...aurant-card/src/components/subcomponents/RestaurantRating/_tests/RestaurantRating.test.js b/...aurant-card/src/components/subcomponents/RestaurantRating/_tests/RestaurantRating.test.js
@@ -47,13 +47,13 @@ describe('RestaurantRating component', () => {
     });
 
     it.each([
-        [1, '1.00'],
-        [2.5, '2.50'],
-        [4.33, '4.33'],
-        [2.337, '2.34'],
-        [4.5678902, '4.57'],
-        [4.5538902, '4.55']
-    ])('fixes the rating mean value to a fixed point of 2 decimal places', (ratingsValue, expectedRenderedValue) => {
+        [1, '1.0'],
+        [2.5, '2.5'],
+        [4.33, '4.3'],
+        [2.337, '2.3'],
+        [4.5678902, '4.6'],
+        [4.5538902, '4.6']
+    ])('fixes the rating mean value to a fixed point of 1 decimal place', (ratingsValue, expectedRenderedValue) => {
         // arrange
         const propsData = {
             mean: ratingsValue,
@@ -118,7 +118,7 @@ describe('RestaurantRating component', () => {
             expect(filledStarElement.exists()).toBe(true);
             expect(ownRatingMessageElement.exists()).toBe(true);
 
-            expect(ratingsMeanElement.text()).toStrictEqual('5.00');
+            expect(ratingsMeanElement.text()).toStrictEqual('5.0');
             expect(ownRatingMessageElement.text()).toStrictEqual(isOwnRatingMessage);
         });
 
@@ -188,8 +188,8 @@ describe('RestaurantRating component', () => {
             expect(filledStarElement.exists()).toBe(true);
             expect(countMessage.exists()).toBe(true);
 
-            expect(ratingsMeanElement.text()).toStrictEqual('5.00');
-            expect(countMessage.text()).toStrictEqual('250');
+            expect(ratingsMeanElement.text()).toStrictEqual('5.0');
+            expect(countMessage.text()).toStrictEqual('200+');
         });
 
         it('shows an empty star and a no ratings message if `mean` is missing', () => {