-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected] #2350
Merged
Merged
[email protected] #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleynolan
reviewed
Nov 21, 2023
ashleynolan
reviewed
Nov 21, 2023
ashleynolan
reviewed
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few SCSS comments – otherwise looks good to me.
Also, could you remove the extra yarn.lock files that were committed? (there was a backup/base/local/remote file added with the PR)
packages/components/pages/f-self-exclusion/src/components/SelfExclusion.vue
Outdated
Show resolved
Hide resolved
packages/components/pages/f-self-exclusion/src/components/SelfExclusion.vue
Outdated
Show resolved
Hide resolved
packages/components/pages/f-self-exclusion/src/components/SelfExclusion.vue
Outdated
Show resolved
Hide resolved
packages/components/pages/f-self-exclusion/src/components/SelfExclusion.vue
Outdated
Show resolved
Hide resolved
packages/components/pages/f-self-exclusion/src/components/SelfExclusion.vue
Outdated
Show resolved
Hide resolved
packages/components/pages/f-self-exclusion/src/components/SelfExclusion.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Ashley Watson-Nolan <[email protected]>
ashleynolan
previously approved these changes
Nov 22, 2023
…components into f-self-exclusion
packages/components/pages/f-self-exclusion/src/components/_tests/SelfExclusion.test.js
Show resolved
Hide resolved
packages/components/pages/f-self-exclusion/src/services/providers/selfExclusion.api.js
Show resolved
Hide resolved
packages/components/pages/f-self-exclusion/src/services/providers/selfExclusion.api.js
Show resolved
Hide resolved
jamieomaguire
approved these changes
Nov 22, 2023
ashleynolan
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Self-exclusion page component. Self-exclusion refers to the process where a customer opts to exclude themselves from an online alcohol delivery service.
Translations to currently in progress and will be implemented in a follow-up PR.
All commits are with --no-verify due to tests failing for f-checkout component, as agreed.
All tests for this component have been passed successfully.