Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #2350

Merged
merged 34 commits into from
Nov 22, 2023
Merged

[email protected] #2350

merged 34 commits into from
Nov 22, 2023

Conversation

m-axii
Copy link
Contributor

@m-axii m-axii commented Nov 6, 2023

Implemented Self-exclusion page component. Self-exclusion refers to the process where a customer opts to exclude themselves from an online alcohol delivery service.

Translations to currently in progress and will be implemented in a follow-up PR.

All commits are with --no-verify due to tests failing for f-checkout component, as agreed.

All tests for this component have been passed successfully.

@github-actions github-actions bot added the pages This PR changes at least one "page" component label Nov 6, 2023
package.json.orig Outdated Show resolved Hide resolved
Copy link
Contributor

@ashleynolan ashleynolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few SCSS comments – otherwise looks good to me.

Also, could you remove the extra yarn.lock files that were committed? (there was a backup/base/local/remote file added with the PR)

@m-axii m-axii requested a review from ashleynolan November 22, 2023 09:58
ashleynolan
ashleynolan previously approved these changes Nov 22, 2023
@ashleynolan ashleynolan merged commit 1f361b7 into master Nov 22, 2023
20 checks passed
@ashleynolan ashleynolan deleted the f-self-exclusion branch November 22, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pages This PR changes at least one "page" component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants