Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure GitHub Actions chrome version is used when running tests #trivial #2365

Closed
wants to merge 4 commits into from

Conversation

siggerzz
Copy link
Contributor

@siggerzz siggerzz commented Nov 14, 2023

  • This PR updates to a new version of WebDriverIO that handles the automatic downloading of Chromedriver.
  • I also had to add a new 'resolution for 'typesafe-i18n' to prevent f-loyalty's build from failing. - This was caused by an incompatible sub-dependency version. This new resolution forces the working version to be used.

@github-actions github-actions bot added the organisms This PR changes at least one "organism" component label Nov 15, 2023
JoshuaNg2332
JoshuaNg2332 previously approved these changes Nov 15, 2023
@@ -42,7 +41,7 @@ exports.config = {
connectionRetryCount: configuration.connectionRetryTimeout,
// Framework you want to run your specs with.
// The following are supported: Mocha, Jasmine, and Cucumber
// see also: https://webdriver.io/docs/frameworks.html
// see also: https://webdriver.io/docs/frameworks tml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// see also: https://webdriver.io/docs/frameworks tml
// see also: https://webdriver.io/docs/frameworks.html

@github-actions github-actions bot added pages This PR changes at least one "page" component services This PR changes at least one "service" package labels Nov 15, 2023
@siggerzz siggerzz closed this Nov 15, 2023
@siggerzz siggerzz deleted the chromedriver-ci-fix branch November 15, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
organisms This PR changes at least one "organism" component pages This PR changes at least one "page" component services This PR changes at least one "service" package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants