Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chromedriver and ignore engines #trivial #2367

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

siggerzz
Copy link
Contributor

@siggerzz siggerzz commented Nov 15, 2023

The new version of Chromedriver requires Node 18 what results in browser tests currently failing. Given the legacy status of this repo and the effort required to add Node 18 support, I'm added a new flag in .yarnrc to ignore the engines field set by our deps.

@siggerzz siggerzz merged commit 73b9675 into master Nov 15, 2023
17 checks passed
@siggerzz siggerzz deleted the update-chromedriver-v2 branch November 15, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants