[email protected]: Add new prop f-restaurant card for review threshold #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
molecules
mmakwe-onyeka
changed the title
mmakwe-onyeka
changed the title
...estaurant-card/src/components/subcomponents/RestaurantRating/_tests/RestaurantRating.test.js
Outdated
Show resolved
Hide resolved
mmakwe-onyeka
force-pushed
the
f-restaurant-card/add-prop-max-rating
branch
from
35dddc1 to
755e17d
Compare
mmakwe-onyeka
force-pushed
the
f-restaurant-card/add-prop-max-rating
branch
from
755e17d to
3abd58f
Compare
Charlotte-91
previously approved these changes
Apr 10, 2024
...estaurant-card/src/components/subcomponents/RestaurantRating/_tests/RestaurantRating.test.js
Show resolved
Hide resolved
...estaurant-card/src/components/subcomponents/RestaurantRating/_tests/RestaurantRating.test.js
Outdated
Show resolved
Hide resolved
...estaurant-card/src/components/subcomponents/RestaurantRating/_tests/RestaurantRating.test.js
Outdated
Show resolved
Hide resolved
...estaurant-card/src/components/subcomponents/RestaurantRating/_tests/RestaurantRating.test.js
Outdated
Show resolved
Hide resolved
...estaurant-card/src/components/subcomponents/RestaurantRating/_tests/RestaurantRating.test.js
Outdated
Show resolved
Hide resolved
...estaurant-card/src/components/subcomponents/RestaurantRating/_tests/RestaurantRating.test.js
Show resolved
Hide resolved
mmakwe-onyeka
force-pushed
the
f-restaurant-card/add-prop-max-rating
branch
from
c8f59a8 to
c43d21f
Compare
jamieomaguire
previously approved these changes
Apr 11, 2024
| expect(countMessage.text()).toStrictEqual('200+'); | ||
| }); | ||
|
|
||
| it('displays threshold when count is higher than threshold with default threshold value', () => { |
There was a problem hiding this comment.
maybe mention it shows with a +?
jamieomaguire
approved these changes
Apr 11, 2024
...lecules/f-restaurant-card/src/components/subcomponents/RestaurantRating/RestaurantRating.vue
Outdated
Show resolved
Hide resolved
xander-marjoram
previously approved these changes
Apr 11, 2024
jamieomaguire
requested changes
Apr 11, 2024
There was a problem hiding this comment.
I would prefer the prop name suggested by @xander-marjoram please
jamieomaguire
previously approved these changes
Apr 12, 2024
mmakwe-onyeka
force-pushed
the
f-restaurant-card/add-prop-max-rating
branch
from
5d855a8 to
ce06131
Compare
xander-marjoram
approved these changes
Apr 12, 2024
Charlotte-91
approved these changes
Apr 16, 2024
jamieomaguire
approved these changes
Apr 16, 2024
|
Merging as the failing test appears to be flakey and unreleated to this PR. @xander-marjoram and @ashleynolan lets catch up about this soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Add new prop for max review number