Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] Update supported country list & change redirection from twitter to X platform #2530

Merged
merged 7 commits into from
May 22, 2024

Conversation

phatpt8
Copy link
Contributor

@phatpt8 phatpt8 commented May 21, 2024

This is the standard PR description template.

Delete the parts of this template that aren’t relevant to the current PR you are submitting – for example, you may not need to amend documentation or testing of the component.


A short description of your PR goes here. Feel free to copy & paste the CHANGELOG entry that you've added here.

  • Stop Portugal, Romania, and New Zealand support
  • Support new country Slovakia
  • Redirect user from Twitter to X
    • still keep the Twitter icon because it is not available in the Icon package
    • Keep the same GTM tag so as not to affect the tracking data.

UI Review Checks

image

  • README and/or UI Documentation has been [created|updated]
  • Unit tests have been [created|updated]
  • This code has been checked with regard to our accessibility standards

Browsers Tested

  • Chrome (latest)
  • Internet Explorer 11
  • Mobile (Please list device/browser – Ideally one iPhone model and one Android)

List any other browsers that this PR has been tested in:

@github-actions github-actions bot added the organisms This PR changes at least one "organism" component label May 21, 2024
@phatpt8 phatpt8 marked this pull request as ready for review May 21, 2024 14:53
@phatpt8 phatpt8 changed the title [email protected] Stop Portugal, Romania, and New Zealand support & Redirect user from Twitter to X [email protected] Update supported country list & change redirection from twitter to X platform May 21, 2024
@xander-marjoram xander-marjoram merged commit dd2837a into master May 22, 2024
21 checks passed
@xander-marjoram xander-marjoram deleted the wcp-944-fix-footer-tests branch May 22, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
organisms This PR changes at least one "organism" component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants