Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] - Fix Published NPM package is missing esm folder #2541

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

zlatinivanov-je
Copy link
Contributor

Published NPM package is missing esm folder

Screenshot 2024-06-20 at 14 28 38

See: https://unpkg.com/browse/@justeat/[email protected]/

Fixes

  • Causes error Module not found: Error: Can't resolve '@justeat/f-vue-icons' in '...project'
    • Regression that seem to have been introduced since v.14

@zlatinivanov-je zlatinivanov-je self-assigned this Jun 20, 2024
@github-actions github-actions bot added the tools This PR changes at least one "tool" label Jun 20, 2024
@zlatinivanov-je zlatinivanov-je added bug Something isn't working please review labels Jun 20, 2024
@fozzie-bot
Copy link

Fails
🚫 ❗ PR title should start with the package version in the format {package-name}@v(x.x.x) (such as [email protected])

Generated by 🚫 dangerJS against d94b5de

@xander-marjoram xander-marjoram changed the title @justeat/[email protected] Fix Published NPM package is missing esm folder [email protected] - Fix Published NPM package is missing esm folder Jun 21, 2024
@ashleynolan ashleynolan merged commit 2bc4131 into master Jun 21, 2024
14 of 27 checks passed
@ashleynolan ashleynolan deleted the f-vue-icons/npm-fix branch June 21, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working please review tools This PR changes at least one "tool"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants