Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-button): DSW-000 styling allowing for text-overflow in buttons #1089

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

ashleynolan
Copy link
Contributor

@ashleynolan ashleynolan commented Dec 9, 2023

Describe your changes

  • [Changed] - Styling allowing for text-overflow in buttons

Before

Screenshot 2024-01-15 at 16 15 19

After

Screenshot 2024-01-15 at 16 15 56

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • I have reviewed visual test updates properly before approving
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists (complete before approving)

Reviewer 1 - @fernandofranca

  • If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2 - @jamieomaguire

  • [-] N/A If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Dec 9, 2023

🦋 Changeset detected

Latest commit: 44ce36d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@justeattakeaway/pie-button Minor
pie-storybook Patch
@justeattakeaway/pie-cookie-banner Patch
@justeattakeaway/pie-modal Patch
@justeattakeaway/pie-toast Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 December 9, 2023 10:39 Inactive
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 December 11, 2023 10:10 Inactive
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 December 13, 2023 11:12 Inactive
@ashleynolan ashleynolan force-pushed the dsw-000-buttonoverflow branch from 7545061 to abb57e6 Compare January 8, 2024 10:47
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 January 8, 2024 10:55 Inactive
@ashleynolan ashleynolan force-pushed the dsw-000-buttonoverflow branch from abb57e6 to 194cd01 Compare January 11, 2024 10:53
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 January 11, 2024 11:01 Inactive
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 January 15, 2024 14:17 Inactive
@ashleynolan
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

The build failed, please see the logs or take a look at the Workflow Tooling wiki page to make sure your PR meets the requirements.

@ashleynolan ashleynolan force-pushed the dsw-000-buttonoverflow branch from 2261644 to 85563c8 Compare January 15, 2024 14:56
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 January 15, 2024 15:04 Inactive
@ashleynolan ashleynolan marked this pull request as ready for review January 15, 2024 16:14
@ashleynolan ashleynolan requested review from a team as code owners January 15, 2024 16:14
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 January 15, 2024 16:20 Inactive
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 January 15, 2024 16:53 Inactive
@ashleynolan ashleynolan marked this pull request as draft January 15, 2024 16:59
@ashleynolan ashleynolan force-pushed the dsw-000-buttonoverflow branch from 9c68193 to 85563c8 Compare January 16, 2024 09:22
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 January 16, 2024 09:29 Inactive
raoufswe
raoufswe previously approved these changes Jan 16, 2024
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 January 17, 2024 16:43 Inactive
@ashleynolan ashleynolan marked this pull request as draft January 18, 2024 14:52
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 January 18, 2024 14:59 Inactive
@ashleynolan ashleynolan dismissed stale reviews from raoufswe and kevinrodrigues via b46c6f7 July 27, 2024 09:34
@ashleynolan ashleynolan force-pushed the dsw-000-buttonoverflow branch from 967ab5e to b46c6f7 Compare July 27, 2024 09:34
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-1089 July 27, 2024 09:41 Inactive
@ashleynolan ashleynolan force-pushed the dsw-000-buttonoverflow branch 2 times, most recently from 022744a to e5cccfc Compare November 25, 2024 10:20
@ashleynolan ashleynolan marked this pull request as ready for review November 25, 2024 10:21
@ashleynolan ashleynolan force-pushed the dsw-000-buttonoverflow branch 2 times, most recently from 44de362 to e1c9156 Compare November 28, 2024 12:08
@ashleynolan
Copy link
Contributor Author

/test-aperture

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

The build failed, please see the logs or take a look at the Workflow Tooling wiki page to make sure your PR meets the requirements.

@ashleynolan ashleynolan force-pushed the dsw-000-buttonoverflow branch from e1c9156 to dcb32f6 Compare November 28, 2024 12:35
@ashleynolan
Copy link
Contributor Author

/test-aperture

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@ashleynolan Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@ashleynolan ashleynolan merged commit 59743d9 into main Nov 29, 2024
36 of 39 checks passed
@ashleynolan ashleynolan deleted the dsw-000-buttonoverflow branch November 29, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants