feat(pie-icons-webc): DSW-000 set height and width on icon hosts #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 03e9232 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dandel10n
previously approved these changes
Mar 29, 2024
…low up) (#1368) feat(pie-icons-webc): DSW-000 removes --icon-display-override var --icon-display-override var is not needed after adding display inline-block to a host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
Applies height and width to web component
hostalong with a display inline block. Otherwise, the web component hosts are incorrectly sized. Image attached to demoAuthor Checklist (complete before requesting a review)
PIE Docschange, I have reviewed the Docs site previewReviewer checklists (complete before approving)
Reviewer 1
PIE Docschange, I have reviewed the PR previewReviewer 2
PIE Docschange, I have reviewed the PR preview