Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-card): DSW-2426 image opacity when disabled #1946

Merged
merged 15 commits into from
Sep 26, 2024

Conversation

kevinrodrigues
Copy link
Contributor

@kevinrodrigues kevinrodrigues commented Sep 23, 2024

Please click the Preview tab and select a different PR template if your change isn't for an existing web component.

PIE Docs Template
New Web Component Template

Screenshot

Screenshot 2024-09-23 at 11 13 12

═══════════════════════════════════════════════════════════

Describe your changes (can list changeset entries if preferable)

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • I have reviewed the PIE Storybook/PIE Docs PR preview

Reviewer checklists (complete before approving)

Reviewer 1 - @xander-marjoram

  • I have reviewed the PIE Storybook PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2 @leksaBoiko

  • I have reviewed the PIE Storybook PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: 9ff60f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@justeattakeaway/pie-card Minor
pie-storybook Patch
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-next10 Patch
wc-next13 Patch
wc-nuxt2 Patch
wc-nuxt3 Patch
wc-react17 Patch
wc-react18 Patch
wc-vanilla Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kevinrodrigues kevinrodrigues marked this pull request as ready for review September 24, 2024 08:48
@kevinrodrigues kevinrodrigues requested review from a team as code owners September 24, 2024 08:48
@kevinrodrigues
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@kevinrodrigues Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

@kevinrodrigues
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

The build failed, please see the logs or take a look at the Workflow Tooling wiki page to make sure your PR meets the requirements.

@kevinrodrigues
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

The build failed, please see the logs or take a look at the Workflow Tooling wiki page to make sure your PR meets the requirements.

@kevinrodrigues
Copy link
Contributor Author

/snapit

@pie-design-system-bot
Copy link
Contributor

Starting a new snapshot build. You can view the logs here.

@pie-design-system-bot
Copy link
Contributor

@kevinrodrigues Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile
yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

packages/components/pie-card/src/index.ts Show resolved Hide resolved
.changeset/mean-planets-begin.md Show resolved Hide resolved
@leksaBoiko
Copy link
Contributor

Could you add a description of the properties instead of a colon in the visual tests?

Screenshot 2024-09-26 at 11 46 50

@leksaBoiko leksaBoiko self-requested a review September 26, 2024 08:49
@kevinrodrigues kevinrodrigues merged commit db1d4c8 into main Sep 26, 2024
32 checks passed
@kevinrodrigues kevinrodrigues deleted the dsw-2426-image-opacity branch September 26, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants