Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie-docs): DSW-2327 content update changes in text input documentation #1962

Merged
merged 6 commits into from
Oct 8, 2024

Conversation

raoufswe
Copy link
Member

@raoufswe raoufswe commented Oct 1, 2024

Describe your changes (can list changeset entries if preferable)

[Fixed] - Content update changes in the text input documentation

  • I also renamed some picture names to be more readable. ~

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • I have reviewed visual test updates properly before approving

Reviewer checklists (complete before approving)

Reviewer 1 - @jamieomaguire

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2 - @ashleynolan

  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Oct 1, 2024

🦋 Changeset detected

Latest commit: 1c1aebc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
pie-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@raoufswe raoufswe marked this pull request as ready for review October 1, 2024 14:51
@raoufswe raoufswe requested review from a team as code owners October 1, 2024 14:51
jamieomaguire
jamieomaguire previously approved these changes Oct 4, 2024
xander-marjoram
xander-marjoram previously approved these changes Oct 4, 2024
@xander-marjoram xander-marjoram self-requested a review October 4, 2024 14:49
@xander-marjoram
Copy link
Contributor

A couple of images aren't loading, I think they might need updating:

https://pr1962-docs.pie.design/components/text-input/#card-number
https://pr1962-docs.pie.design/components/text-input/#payment-method-1

@raoufswe raoufswe dismissed stale reviews from xander-marjoram and jamieomaguire via 76766dc October 4, 2024 16:32
@raoufswe raoufswe self-assigned this Oct 4, 2024
@raoufswe raoufswe force-pushed the dsw-2327-content-updates-text-input branch from 76766dc to 99f991b Compare October 4, 2024 16:58
ashleynolan
ashleynolan previously approved these changes Oct 7, 2024
@raoufswe raoufswe merged commit 76d310c into main Oct 8, 2024
33 of 34 checks passed
@raoufswe raoufswe deleted the dsw-2327-content-updates-text-input branch October 8, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants