fix(pie-modal): DSW-2218 stop esc closing modal (isDismissible=false)

[jamieomaguire]

Describe your changes (can list changeset entries if preferable)

• Prevents Escape key presses from closing the modal when iDismissible is set to false
• Applies the same protection against reactive changes to the isDismissible property
• Enables the previously skipped test that captured the bug

How to test

1. Go to the default Modal story in the Storybook preview deploy
2. Try pressing escape
3. The Modal should close
4. Now set the isDismissible control to false
5. Try pressing escape
6. The Modal should not close
7. Try various combinations to see if lifecycle changes affect the behaviour (they don't when I have tested but worth a second person checking)

Author Checklist (complete before requesting a review)

• I have performed a self-review of my code
• I have added thorough tests where applicable (unit / component / visual)
• I have reviewed the PIE Storybook PR preview
• I have reviewed visual test updates properly before approving
• If changes will affect consumers of the package, I have created a changeset entry.
• If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists (complete before approving)

Reviewer 1 - Fernando

• I have reviewed the PIE Storybook PR preview

Reviewer 2 - @xander-marjoram

• I have reviewed the PIE Storybook PR preview

[changeset-bot]

🦋 Changeset detected

Latest commit: 7c0d0de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@justeattakeaway/pie-modal	Minor
pie-storybook	Patch
@justeattakeaway/pie-cookie-banner	Patch
@justeattakeaway/pie-webc	Patch
wc-angular12	Patch
wc-next10	Patch
wc-next13	Patch
wc-nuxt2	Patch
wc-nuxt3	Patch
wc-react17	Patch
wc-react18	Patch
wc-vanilla	Patch
wc-vue3	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[jamieomaguire]

/test-aperture

[pie-design-system-bot]

Starting a new snapshot build. You can view the logs here.

[pie-design-system-bot]

@jamieomaguire Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile

yarn up @justeattakeaway/[email protected] --mode=update-lockfile

yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

[jamieomaguire]

/test-aperture

[pie-design-system-bot]

Starting a new snapshot build. You can view the logs here.

[pie-design-system-bot]

@jamieomaguire Your snapshots have been published to npm!

Test the snapshots by updating your package.json with the newly-published versions:

Note

If you have more than one of these packages installed, we suggest using the new snapshots for all of them to help avoid version conflicts.

yarn up @justeattakeaway/[email protected] --mode=update-lockfile

yarn up @justeattakeaway/[email protected] --mode=update-lockfile

yarn up @justeattakeaway/[email protected] --mode=update-lockfile

Then finally:

yarn install

[fernandofranca]

👏 👏 👏