Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-toast-provider): DSW-2222 add the toast provider skeleton #2097

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

raoufswe
Copy link
Member

@raoufswe raoufswe commented Nov 27, 2024

Describe your changes (can list changeset entries if preferable)

  • init pie-toast-provider.

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • I have reviewed the PIE Storybook/PIE Docs PR preview
  • I have reviewed visual test updates properly before approving
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have used the /snapit functionality to test my changes in a consuming application

Reviewer checklists

Reviewer 1 - @siggerzz

  • I have reviewed the PIE Storybook/PIE Docs PR preview

Reviewer 2 - @fernandofranca

  • I have reviewed the PIE Storybook/PIE Docs PR preview

Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: c18e430

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@raoufswe raoufswe force-pushed the dsw-2222-toast-provider branch from 9ee5379 to c18e430 Compare November 27, 2024 16:48
@raoufswe raoufswe marked this pull request as ready for review November 27, 2024 16:50
@raoufswe raoufswe requested review from a team as code owners November 27, 2024 16:50
@raoufswe raoufswe merged commit c323aa9 into main Nov 28, 2024
70 of 81 checks passed
@raoufswe raoufswe deleted the dsw-2222-toast-provider branch November 28, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants