Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-icons): DSW-000 update high priority icons #2105

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

maledr5
Copy link
Contributor

@maledr5 maledr5 commented Dec 3, 2024

Describe your changes (can list changeset entries if preferable)

Addressed 2 icons changes that were high priority and highlighted from the backlog.

[Added] Communication

  • share-2
  • share-2-large

[Updated] Pay

  • takeaway-pay
  • takeaway-pay-large
  • takeaway-pay-filled-large
  • takeaway-pay-filled

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed the Docs site preview
  • If there are visual test updates, I have reviewed them properly before approving
  • I have updated doc site snapshot tests with new icon additions

Not-applicable Checklist items

  • I have added thorough tests where applicable (unit / component / visual)

Reviewer checklists (complete before approving)

Reviewer 1 - @fernandofranca

  • I have reviewed the Docs site preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • I have reviewed the Docs site preview
  • If there are visual test updates, I have reviewed them

@maledr5 maledr5 requested review from a team as code owners December 3, 2024 14:44
Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: 018762b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@justeattakeaway/pie-icons Minor
@justeattakeaway/pie-icons-react Minor
@justeattakeaway/pie-icons-vue Minor
@justeattakeaway/pie-icons-webc Minor
pie-docs Patch
pie-storybook Patch
@justeattakeaway/pie-assistive-text Patch
@justeattakeaway/pie-chip Patch
@justeattakeaway/pie-icon-button Patch
@justeattakeaway/pie-modal Patch
@justeattakeaway/pie-notification Patch
@justeattakeaway/pie-switch Patch
@justeattakeaway/pie-text-input Patch
@justeattakeaway/pie-toast Patch
@justeattakeaway/pie-checkbox-group Patch
@justeattakeaway/pie-checkbox Patch
@justeattakeaway/pie-radio-group Patch
@justeattakeaway/pie-textarea Patch
@justeattakeaway/pie-webc Patch
@justeattakeaway/pie-cookie-banner Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maledr5 maledr5 merged commit 78d17bb into main Dec 5, 2024
44 checks passed
@maledr5 maledr5 deleted the DSW-000-icons-update branch December 5, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants