Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pie-chip): DSW-2373 refactor pie-chip component/a11y tests to use @playwright/test #2137

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

siggerzz
Copy link
Contributor

@siggerzz siggerzz commented Jan 6, 2025

Describe your changes (can list changeset entries if preferable)

  • refactor pie-chip component/a11y tests to use @playwright/test

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have reviewed the PIE Storybook/PIE Docs PR preview.

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.

  • [-] - NA I have added thorough tests where applicable (unit / component / visual).
  • [-] - NA If changes will affect consumers of the package, I have created a changeset entry.
  • [-] - NA If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.
  • [-] - NA I have reviewed visual test updates properly before approving.

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1 - @JoshuaNg2332

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] - NA I have reviewed the Aperture changes (if added)
  • [-] - NA If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] - NA I have reviewed the Aperture changes (if added)
  • [-] - NA If there are visual test updates, I have reviewed them.

Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: 6cf0958

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

JoshuaNg2332
JoshuaNg2332 previously approved these changes Jan 6, 2025
JoshuaNg2332
JoshuaNg2332 previously approved these changes Jan 6, 2025
@siggerzz siggerzz merged commit d7370ee into main Jan 7, 2025
31 of 32 checks passed
@siggerzz siggerzz deleted the dsw-2373-pie-chip-refactor branch January 7, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants