Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-breadcrumb): DSW-2830 create basic component markup #2257

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

thejfreitas
Copy link
Member

@thejfreitas thejfreitas commented Mar 4, 2025

Adding basic html markup and basic styling to the pie-breadcrumb component

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • If changes will affect consumers of the package, I have created a changeset entry.
  • If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Not-applicable Checklist items

Please move any Author checklist items that do not apply to this pull request here.


Testing

How do I test my changes?

Task Link
Aperture PR 🔗
NextJS 14 deployment 🔗
Nuxt 3 deployment 🔗
Vanilla deployment 🔗

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@thejfreitas thejfreitas self-assigned this Mar 4, 2025
@thejfreitas thejfreitas requested review from a team as code owners March 4, 2025 21:53
Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: 220d198

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pie-design-system-bot
Copy link
Contributor

pie-design-system-bot commented Mar 4, 2025




Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 1's section.

Please ensure all items are addressed before approval.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against 220d198

@github-actions github-actions bot temporarily deployed to storybook-pr-2257 March 4, 2025 21:58 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2257 March 4, 2025 21:58 Inactive
@github-actions github-actions bot temporarily deployed to storybook-pr-2257 March 4, 2025 22:16 Inactive
@github-actions github-actions bot temporarily deployed to storybook-testing-pr-2257 March 4, 2025 22:16 Inactive
@siggerzz
Copy link
Contributor

siggerzz commented Mar 5, 2025

Thanks for the contribution @thejfreitas 🎉

Just running the visual tests again, as I've just created a new project in Percy for this component 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants