Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-monorepo): DSW-1079 provide VSCode extensions recommendations for users #956

Merged
merged 6 commits into from
Nov 2, 2023

Conversation

siggerzz
Copy link
Contributor

@siggerzz siggerzz commented Nov 2, 2023

Describe your changes (can list changeset entries if preferable)

This PR adds functionality so that users of the PIE Monorepo will get a notification to installed recommended extensions when they open the PIE Monorepo:

Notification
Screenshot 2023-11-02 at 11 02 36

VSCode Extensions Tab
Screenshot 2023-11-02 at 11 02 49

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • If it is a PIE Docs change, I have reviewed the Docs site preview
  • If it is a component change, I have reviewed the Storybook preview
  • If there are visual test updates, I have reviewed them properly before approving

Reviewer checklists (complete before approving)

Reviewer 1

  • If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them

Copy link

changeset-bot bot commented Nov 2, 2023

🦋 Changeset detected

Latest commit: 58f03cc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fernandofranca
Copy link
Contributor

Lit syntax highlighter: https://marketplace.visualstudio.com/items?itemName=runem.lit-plugin

Pretty TypeScript Errors: https://marketplace.visualstudio.com/items?itemName=yoavbls.pretty-ts-errors

@siggerzz siggerzz marked this pull request as ready for review November 2, 2023 12:50
@siggerzz siggerzz requested review from a team as code owners November 2, 2023 12:50
@siggerzz siggerzz merged commit 2fc7687 into main Nov 2, 2023
@siggerzz siggerzz deleted the dsw-000-vscode-recommended-extensions branch November 2, 2023 16:47
@siggerzz siggerzz changed the title feat(pie-monorepo): DSW-000 provide VSCode extensions recommendations for users feat(pie-monorepo): DSW-1079 provide VSCode extensions recommendations for users Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants