Feature: Provide support for RDS MySQL IAM Authentication #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dewey Let me know if you'd like any other changes made! 👍 |
dewey
reviewed
Sep 26, 2024
job.go
Outdated
| return token, expirationTime, nil | ||
| } | ||
|
|
||
| // // Function to setup RDS MySQL IAM Auth |
|
Apologies @dewey - I've removed the commented section. |
|
All looks good, thanks for your contribution! I'm going to merge it and release a new version. 🙌 |
|
Thank you. I'll wait for that release to be built as I'm using the built container release in some of my Ansible builds! 👍 |
|
https://github.com/justwatchcom/sql_exporter/releases/tag/v0.5.6 is out, the image is pushing right now and should be available in ~15 min. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've modified this slightly to also support MySQL RDS IAM authentication (much the same as Postgres RDS IAM Authentication) - I've just combined the
mysql://andrds-mysql://together and handled it there.I've tested this on MySQL both with and without IAM authentication and appears to work fine!