Uncommenting Bool

[dstarkenburg]

Uncommenting Bool and converting Python's Bool datatype directly to Bool in julia does not seem to cause any issues and actually made the onnx layer 'And' load correctly (at least without broadcasting, but that part is on me).

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.82%. Comparing base (5ed108b) to head (84b722f).
Report is 19 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   88.37%   85.82%   -2.56%     
==========================================
  Files           4        4              
  Lines         387      402      +15     
==========================================
+ Hits          342      345       +3     
- Misses         45       57      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jw3126]

@dstarkenburg can you bump the patch version?

[GunnarFarneback]

I don't think Python's datatypes have anything to do with it since ONNXRunTime is implemented in C++. But combining https://github.com/onnx/onnx/blob/6fab903f0b25eedb5a9d74c47ab095ee97eef0a6/onnx/onnx.proto3#L618 and the discussion in microsoft/onnxruntime#3689, it seems safe to assume that Boolean tensors should use one byte per element, which Julia's Bool does:

julia> sizeof(Bool)
1

[dstarkenburg]

Let me know if that is what you meant by 'bump the patch!' (I have very little experience with github releases)