Depend on StaticArraysCore.jl; remove Requires.jl dependency #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jw3126
reviewed
Aug 5, 2022
jw3126
reviewed
Aug 5, 2022
Co-authored-by: Jan Weidner <[email protected]>
Co-authored-by: Jan Weidner <[email protected]>
|
Thanks for the suggestions; fully agree with both of them. |
|
CI failure was related to Julia 1.0 and 1.3; newest commit switches over to current Julia version (1.7.x), LTS (1.6.x) and nightly. |
jw3126
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StaticArrays has recently been refactored with the interface contained in StaticArraysCore; a much lighter dependency. This allows to remove the dynamic loading of the StaticArrays package, which has the potential to prevent method invalidations during precompilation of downstream packages.
All tests pass locally (Julia 1.7.2).
Also addresses #164