Skip to content

Commit

Permalink
Merge pull request #11 from jw3126/v16
Browse files Browse the repository at this point in the history 
fix tests
  • Loading branch information
@jw3126
jw3126 authored Aug 1, 2024
2 parents 45e72e6 + 1c16c90 commit 081db3d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 5 deletions.
4 changes: 2 additions & 2 deletions Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "StructHelpers"
uuid = "4093c41a-2008-41fd-82b8-e3f9d02b504f"
authors = ["Jan Weidner <[email protected]> and contributors"]
version = "1.3"
version = "1.3.0"

[deps]
ConstructionBase = "187b0558-2788-49d3-abe0-74a17ed4e7c9"
Expand All @@ -11,8 +11,8 @@ ConstructionBase = "1.3"
julia = "1.6"

[extras]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
StructTypes = "856f2bd8-1eba-4b0a-8007-ebc267875bd4"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Test", "StructTypes"]
12 changes: 9 additions & 3 deletions test/runtests.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,15 @@ struct SNoIsEqual; a; end
@test Empty1() != Empty2()
@test hash(Empty1()) != hash(Empty2())

@test_throws "Bad keyword argument value:" @macroexpand @batteries SErrors kwconstructor="true"
@test_throws "Unsupported keyword" @macroexpand @batteries SErrors kwconstructor=true nonsense=true
@test_throws "Expected a keyword argument of the form name = value" @macroexpand @batteries SErrors nonsense
if VERSION >= v"1.8"
@test_throws "Bad keyword argument value:" @macroexpand @batteries SErrors kwconstructor="true"
@test_throws "Unsupported keyword" @macroexpand @batteries SErrors kwconstructor=true nonsense=true
@test_throws "Expected a keyword argument of the form name = value" @macroexpand @batteries SErrors nonsense
else
@test_throws Exception @macroexpand @batteries SErrors kwconstructor="true"
@test_throws Exception @macroexpand @batteries SErrors kwconstructor=true nonsense=true
@test_throws Exception @macroexpand @batteries SErrors nonsense
end


@testset "typesalt" begin
Expand Down

2 comments on commit 081db3d

@jw3126
Copy link
Owner Author

@jw3126 jw3126 commented on 081db3d Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/112195

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.3.0 -m "<description of version>" 081db3de89775b9143b13f3d3e5b69b078c4e336
git push origin v1.3.0

Also, note the warning: Version 1.3.0 skips over 1.2.0
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

Please sign in to comment.