Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added operations to the readme #59

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

westlakem
Copy link

No description provided.

@jwadhams
Copy link
Owner

I really like this idea, I think it belongs in the Customization section. Does this edit still work for you?

Copy link

@josephdpurcell josephdpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README already refers to https://jsonlogic.com/add_operation.html which has lots of info.

It might be beneficial to leave the add_operation out of the readme in favor of the readme being minimal?

Suggested changes commented below -- perhaps the examples from https://jsonlogic.com/add_operation.html could be put here? That is, assuming adding examples in the readme is desired.

return age < 65;
}

function greatherThanNumber(age) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is misleading. greatherThanNumber is actually greaterThanOrEqualToNumber.

You can perform custom operations on your dataset using `add_operation`

```js
function lessThanNumber(age) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name lessThanNumber suggests to me that the operation would let you pick which number it is less than. Really this is lessThan65.

@josephdpurcell
Copy link

One additional note: I did test the examples to make sure they work, and they do in fact work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants