Feature skip all button implemented #75
Conversation
|
Hey @imVinayPandya, cheers for this PR. Left a couple of review points, but it also looks like you may have branched off |
|
@jwarby okay I will do that. Thank you |
There was a problem hiding this comment.
Hey @imVinayPandya, sorry I added these review comments the other day but didn't realise I had to submit the review as well (first time using this feature!). Could you apply the requested changes from this review onto your new PR please? 😄
| show: function() { | ||
| return isFirstStep(); | ||
| } | ||
| }, |
There was a problem hiding this comment.
I think we should default this to false, chances are that existing users probably won't want this functionality to be turned on by default.
There was a problem hiding this comment.
okay that's okay i can do that.
| @@ -889,6 +890,10 @@ | |||
| /* Close and finish tour buttons clicks */ | |||
| $(document).on('click', '#jpwClose, #jpwFinish', methods.close); | |||
|
|
|||
| /* Skip All to skip all tour steps | |||
| */ | |||
| $(document).on('click', '#jpwSkipAll', methods.close); | |||
There was a problem hiding this comment.
I guess we can probably move this selector into the one above (ie with #jpwClose and #jpwFinish) since they're both calling methods.close.
There was a problem hiding this comment.
oooppps! okay i missed that.
I have added skip all button, which will show up on first steps of Walkthrough.
Reason for implementing "Skip All" button: I was using this plugin with ionic 3 mobile apps. I don't need the close button because of close button position. at close button position in mobile, I need to place one highlighted tooltip. which is overlapping close button. that is why I added skip all button on the first step which allows the user to close Walkthrough at first step.