fix: prevent iOS crash when Google Cast is not enabled and React Native's new architecture is #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriszs
changed the title
chriszs
changed the title
chriszs
changed the title
AmitaiB
changed the title
|
Thanks, @chriszs. This resolves the build issue for iOS. We have some internal tickets to ensure we best support the new architecture, but this should get everyone started on iOS, at least. I think something with the new architecture is breaking our Android implementation. We will address this with our internal ticket unless you or someone wants to tackle it first |
Jmilham21
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Removes the cast methods from the list of methods exported to React Native on iOS when
USE_GOOGLE_CASTis not enabled.Why is this Pull Request needed?
iOS apps without this crash on React Native's new architecture after being built with Google Cast support, because otherwise the code tries to reference missing methods.
Are there any points in the code the reviewer needs to double check?
No.
Are there any Pull Requests open in other repos which need to be merged with this?
No.
Addresses Issue(s):
GitHub Issue