Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore / payments e2e tests stability improvements #658

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

ChristiaanScheermeijer
Copy link
Collaborator

Description

I found that the payments e2e tests were failing many times and while looking into this I found some problems in the tests and a bug in the payments form. These fixes should be rebased to #656 and #657.

  • The loading times can vary a lot and the biggest culprit was the timeout of I.waitForLoaderDone(), so I increased the timeout for this test specifically
  • The SubscriptionService couldn't be injected due to an error in the test build caused by a missing @inject() annotation
  • The Checkout form was showing the Adyen card payment form while no payment was needed. This caused the coupon test to fail

Copy link

github-actions bot commented Dec 4, 2024

Visit the preview URL for this PR (updated for commit 2615f3f):

https://ottwebapp--pr658-chore-e2e-stability-sttpzlqy.web.app

(expires Fri, 03 Jan 2025 13:48:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

Copy link
Collaborator

@langemike langemike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice appropriate fixes. Glad you were able to fix this e2e issue

@ChristiaanScheermeijer ChristiaanScheermeijer merged commit 08a72b0 into develop Dec 4, 2024
10 checks passed
@ChristiaanScheermeijer ChristiaanScheermeijer deleted the chore/e2e-stability-improvements branch December 4, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants