Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add properties for graalvm #971

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XenoAmess
Copy link

@XenoAmess XenoAmess commented Oct 17, 2024

as title.
at least usable in my repo.

Copy link
Member

@bdemers bdemers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a native-image fan, but this type of thing has always been the hard part.

My main concern is we want to make sure it's easy to maintain as the codebase evolves

"resources": {
"includes": [
{
"pattern": "META-INF/services/io.jsonwebtoken.CompressionCodec"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a handful of services, though these should possibly live in their corresponding module, and not in jjwt-api, thoughts?

./impl/src/main/resources/META-INF/services/io.jsonwebtoken.CompressionCodec
./extensions/gson/src/main/resources/META-INF/services/io.jsonwebtoken.io.Serializer
./extensions/gson/src/main/resources/META-INF/services/io.jsonwebtoken.io.Deserializer
./extensions/orgjson/src/main/resources/META-INF/services/io.jsonwebtoken.io.Serializer
./extensions/orgjson/src/main/resources/META-INF/services/io.jsonwebtoken.io.Deserializer
./extensions/jackson/src/main/resources/META-INF/services/io.jsonwebtoken.io.Serializer
./extensions/jackson/src/main/resources/META-INF/services/io.jsonwebtoken.io.Deserializer

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it all in -api for maintaner to maintain them easier, no need to worry about what modification shall look for which json
but yes, logically it should be split into each module

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to try to write a maven-plugin to auto-generate it, so the two problems shall both be solved.

@@ -0,0 +1,209 @@
[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any thoughts on generating this list at build time?
This is going to be difficult to maintain and track if/when these method signatures change.

Any ideas on creating a test harness? (Extra points if it doesn't require slowly creating a native image in order to test it).

Copy link
Author

@XenoAmess XenoAmess Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as for generating I have no idea either, maybe I have to make another maven-plugin for it.
for test, unfortunatly I have no idea how to make it test native fastly.
the native image building is...well, slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants