Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fullWidth): Fix secondary navbar having a max width #477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YorikHansen
Copy link
Collaborator

Old:
grafik

New:
grafik

@YorikHansen YorikHansen requested a review from jxn-30 November 26, 2024 12:15
@YorikHansen YorikHansen added the bug Something isn't working label Nov 26, 2024
@jxn-30
Copy link
Owner

jxn-30 commented Nov 27, 2024

I'm not yet sure which version I prefer. Personally, I like the menu being more or less in the center. How about a solution that keeps the secondary nav in the center and actually centers it?
grafik

.secondary-navigation .navigation .nav-tabs {
    justify-content: center;
}

@YorikHansen
Copy link
Collaborator Author

Hmm, I still like my version more (as I'm used to it). How about moving it into a setting? (We could add another section "Advanced")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants