CCM/CSI credentials propagation #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a13x5
force-pushed
the
ccm-credentials-delivery
branch
5 times, most recently
from
d299e98 to
8565164
Compare
a13x5
force-pushed
the
ccm-credentials-delivery
branch
4 times, most recently
from
dd0cc7f to
a540a5b
Compare
a13x5
force-pushed
the
ccm-credentials-delivery
branch
2 times, most recently
from
886db33 to
ad74070
Compare
Kshatrix
requested changes
Oct 15, 2024
zerospiel
reviewed
Oct 15, 2024
a13x5
force-pushed
the
ccm-credentials-delivery
branch
from
ad74070 to
51889f3
Compare
a13x5
force-pushed
the
ccm-credentials-delivery
branch
from
51889f3 to
8a93509
Compare
a13x5
force-pushed
the
ccm-credentials-delivery
branch
from
8a93509 to
3be612b
Compare
Kshatrix
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #324
Resolves #325
Notes:
Add Credential CR and controllerwill be removed from this PR. Now it's cherry-picked here for clarity.ManagedClusterwill not transition to Ready when some other (than AWS, Azure or vSphere) infrastructure provider will be used. Probably this isn't right.