Strip leading v from VERSION in 'Get outputs' job #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Squizzato <[email protected]>
|
Here's the test running with the change to build confidence that this will fix the controller test: https://github.com/Mirantis/hmc/actions/runs/11394890001/job/31706255408?pr=519 |
Kshatrix
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leading
vwas removed fromVERSIONin #505, but the test outputs get generated outside of theMakefile, this fixes the version used within the test workflow as well. Unfortunately, with the nature ofpull_request_targetthe CI won't pass until merged because this is a workflow file change (we really need to change this behavior when things cool down around here)