Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(openstack): add instructions for OpenStack provider on HMC #727

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

ramessesii2
Copy link
Contributor

@ramessesii2 ramessesii2 commented Dec 9, 2024

- clarify provider setup, environment variables, and recommended image/flavor requirements.
- fix warnings raised by markdownlint.

Related code changes are in #695, #696, #697

zerospiel
zerospiel previously approved these changes Dec 27, 2024
@ramessesii2
Copy link
Contributor Author

/hold
Will be pushing more changes.

@ramessesii2 ramessesii2 force-pushed the RAMESSES/docs-openstack branch 2 times, most recently from 4059f0a to ea01be6 Compare December 31, 2024 04:44
@ramessesii2
Copy link
Contributor Author

/unhold
ready for review

Copy link
Collaborator

@bnallapeta bnallapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments.

docs/dev.md Show resolved Hide resolved
docs/dev.md Outdated Show resolved Hide resolved
docs/dev.md Outdated Show resolved Hide resolved
docs/dev.md Outdated Show resolved Hide resolved
docs/dev.md Outdated Show resolved Hide resolved
docs/dev.md Outdated Show resolved Hide resolved
docs/dev.md Show resolved Hide resolved
@ramessesii2 ramessesii2 force-pushed the RAMESSES/docs-openstack branch 6 times, most recently from 96c8a1a to c6f2b0b Compare December 31, 2024 11:16
    - clarify provider setup, environment variables, and recommended image/flavor requirements
    - cosmetic changes

Signed-off-by: Satyam Bhardwaj <[email protected]>
@ramessesii2 ramessesii2 force-pushed the RAMESSES/docs-openstack branch from c6f2b0b to ed703c5 Compare January 8, 2025 06:10
@zerospiel
Copy link
Contributor

Need somebody with sufficient access to merge the PR without CI jobs

@DinaBelova DinaBelova merged commit bb331e9 into k0rdent:main Jan 8, 2025
@DinaBelova
Copy link
Collaborator

merged with the appropriated code owner review from @zerospiel
(note - had to squash and merge, GH did not allow to rebase and merge for this commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants