Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EKS e2e testing #839

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add EKS e2e testing #839

wants to merge 2 commits into from

Conversation

eromanova
Copy link
Contributor

This PR introduces the following changes:

  1. Added e2e testing to verify the successful deployment of an EKS cluster
  2. Enhanced the EKS template to allow deployment of additional add-ons
  3. Configured the CSI driver add-on to be enabled by default

E2E

E2E testing for EKS deployments is enabled by default and integrated into the AWS provider testing suite. At this time, hosted cluster deployments are not supported for EKS clusters.

Testing Scenario:

  1. Deploy an EKS cluster using the default simple configuration
  2. Verify the deployment of all related objects
  3. Verify the CSI driver
  4. Verify the CCM

P.S. The testing scenario is intentionally kept simple, avoiding complex configurations, as the overall testing strategy is currently under review and subject to potential changes.

Closes #387

And enable CSI driver addon by default
@eromanova eromanova self-assigned this Dec 26, 2024
@eromanova eromanova marked this pull request as ready for review December 27, 2024 10:52
Copy link
Contributor

@zerospiel zerospiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i left an unrelated to the PR comment, could be skipped

return deploymentValidator.Validate(context.Background(), kc)
}, 30*time.Minute, 10*time.Second).Should(Succeed())

if !noCleanup() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not related to the PR: could we change the symbol noCleanup name to the cleanup? it's being used always with negate !noCleanup(), efficiently meaning cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Implement automated testing for EKS templates
2 participants