improve Makefile #843
Open
improve Makefile #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramessesii2
requested review from
Kshatrix,
eromanova,
a13x5 and
zerospiel
as code owners
ramessesii2
force-pushed
the
RAMESSES/makefile-fix
branch
from
725573c to
b5a6438
Compare
zerospiel
reviewed
Dec 30, 2024
ramessesii2
force-pushed
the
RAMESSES/makefile-fix
branch
from
b5a6438 to
3a71599
Compare
a13x5
requested changes
Dec 30, 2024
There was a problem hiding this comment.
Several notes:
- Some parts require additional explanation
- If we're installing
jqwe need to make sure that the samejqis used in all our scripts - Issue with
unzipreported in the Makefile does not check for required binaries presence. #512 is not covered
ramessesii2
force-pushed
the
RAMESSES/makefile-fix
branch
4 times, most recently
from
077133e to
2557f64
Compare
a13x5
requested changes
Jan 9, 2025
- add jq to tools to be installed with make cli-install
- add check for unzip
Signed-off-by: Satyam Bhardwaj <[email protected]>
ramessesii2
force-pushed
the
RAMESSES/makefile-fix
branch
from
2557f64 to
2c40e61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make cli-installunzipFixes #512