e2e test of managed service deployment #873
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BROngineer
force-pushed
the
epic-829/deploy-services-with-servicetemplate
branch
from
b07c28b to
6eb2fed
Compare
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
BROngineer
force-pushed
the
epic-829/deploy-services-with-servicetemplate
branch
from
6eb2fed to
4dcd7e7
Compare
zerospiel
reviewed
Jan 9, 2025
There was a problem hiding this comment.
In general LGTM, a couple of questions/comments, and the PR should be postponed until the e2e CI is ready (as of now and to my understanding it is blocked due to the #871). After addressing the issue, the PR should be then checked with the e2e tests job
| if err != nil { | ||
| return err | ||
| } | ||
| if *dep.Spec.Replicas != dep.Status.ReadyReplicas { |
There was a problem hiding this comment.
it is not a 100% ensure check, could you reuse this function moving it to the public internal utils?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #849