Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only include envoy image in default config if images should be included #3664

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Only include envoy image in default config if images should be included #3664

merged 1 commit into from
Oct 31, 2023

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Oct 31, 2023 •
edited
Loading

Description

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Only include envoy image in default config if images should be included
8d09614 
See: 9f02f27 ("Removes images in k0s config create by default")
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added bug Something isn't working area/cli backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch labels Oct 31, 2023
@twz123 twz123 marked this pull request as ready for review October 31, 2023 17:29
@twz123 twz123 requested a review from a team as a code owner October 31, 2023 17:29
@twz123 twz123 requested review from kke and makhov October 31, 2023 17:29
@twz123 twz123 merged commit 35b481e into k0sproject:main Oct 31, 2023
77 checks passed
@twz123 twz123 deleted the no-envoy-image-in-config branch October 31, 2023 18:04
@k0s-bot
Copy link

k0s-bot commented Oct 31, 2023

Successfully created backport PR for release-1.28:

@k0s-bot k0s-bot mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makhov makhov makhov approved these changes

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
area/cli backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twz123 @k0s-bot @makhov