Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch node object from apiserver when (un)cordoning #3741

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

danj-replicated
Copy link
Contributor

@danj-replicated danj-replicated commented Nov 22, 2023

Description

when cordoning/uncordoning controlNodes for autopilot, fetch Node object from APIserver instead of trying to cast from signalNode.

Fixes #3739

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

we only want to do this if the signalClient isn't a Node type

Signed-off-by: danj-replicated <[email protected]>
@twz123 twz123 added bug Something isn't working component/autopilot backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch labels Nov 23, 2023
Copy link
Member

@twz123 twz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for poking into this!

@twz123 twz123 merged commit bcc1189 into k0sproject:main Nov 23, 2023
74 checks passed
@k0s-bot
Copy link

k0s-bot commented Nov 23, 2023

Successfully created backport PR for release-1.28:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch bug Something isn't working component/autopilot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autopilot "failed to covert signalNode to Node"
3 participants