Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to disable CPLB load balancer #5397

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Allow to disable CPLB load balancer #5397

wants to merge 1 commit into from
+18 −9

Conversation

juanluisvaladas
Copy link
Contributor

Do not merge before getting #5393 and #5396 merged.

Description

This is one of the remaining tasks of #5279. The intended use case for this is to allow to use the VIPs functionality while using some user provided load balancer such as HAProxy, nginx, etc...

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@juanluisvaladas
Allow to disable CPLB load balancer
aa2c695 
This is one of the remaining tasks of k0sproject#5279. The intended use case for
this is to allow to use the VIPs functionality while using some user
provided load balancer such as HAProxy, nginx, etc...

Also fixes some CPLB documentation mistakes spotted while fixing this.

Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>

mend
@juanluisvaladas juanluisvaladas added this to the 1.32 milestone Jan 7, 2025
@juanluisvaladas juanluisvaladas mentioned this pull request Jan 8, 2025
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.
1 participant
@juanluisvaladas