Use localhost in admin kubeconfig again, if possible #5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the API server is binding to all addresses, it's better to use the loopback interface to communicate with the API server locally. This avoids e.g. weird HTTP proxy problems. See: a759281 ("replace BindAddress by Address and OnlyBindToAddress") See: 548dc41 ("Add spec.api.bindAddress configuration") Signed-off-by: Tom Wieczorek <[email protected]>
twz123
added
the
backport/release-1.31
jnummelin
reviewed
Jan 10, 2025
| if a.OnlyBindToAddress { | ||
| host = net.JoinHostPort(a.Address, strconv.Itoa(a.Port)) | ||
| } else { | ||
| host = fmt.Sprintf("localhost:%d", a.Port) |
There was a problem hiding this comment.
Why not use net.JoinHostPort in this case too?
There was a problem hiding this comment.
We could, but we don't need to. JoinHostPort is only necessary if the host may be an IPv6 address, which, in this case, it isn't. Would you prefer to use it anyways?
ncopa
reviewed
Jan 14, 2025
Comment on lines
+77
to
+84
| var host string | ||
| if a.OnlyBindToAddress { | ||
| host = net.JoinHostPort(a.Address, strconv.Itoa(a.Port)) | ||
| } else { | ||
| host = fmt.Sprintf("localhost:%d", a.Port) | ||
| } | ||
|
|
||
| return &url.URL{Scheme: "https", Host: host} |
There was a problem hiding this comment.
It doesn't matter, but....
Suggested change
| var host string | |
| if a.OnlyBindToAddress { | |
| host = net.JoinHostPort(a.Address, strconv.Itoa(a.Port)) | |
| } else { | |
| host = fmt.Sprintf("localhost:%d", a.Port) | |
| } | |
| return &url.URL{Scheme: "https", Host: host} | |
| host := "localhost" | |
| if a.OnlyBindToAddress { | |
| host = a.Address | |
| } | |
| return &url.URL{Scheme: "https", Host: net.JoinHostPort(host, strconv.Itoa(a.Port))} |
ncopa
approved these changes
Jan 14, 2025
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-1.31
git worktree add -d .worktree/backport-5426-to-release-1.31 origin/release-1.31
cd .worktree/backport-5426-to-release-1.31
git switch --create backport-5426-to-release-1.31
git cherry-pick -x 93b9f4ccc221af159d0e978c13fe9f37dfffb49b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the API server is binding to all addresses, it's better to use the loopback interface to communicate with the API server locally. This avoids e.g. weird HTTP proxy problems.
See:
Type of change
How Has This Been Tested?
Checklist: