Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm fields #176

Merged
merged 6 commits into from
Sep 14, 2023
Merged

Update helm fields #176

merged 6 commits into from
Sep 14, 2023

Conversation

dereknola
Copy link
Member

Signed-off-by: Derek Nola [email protected]

Signed-off-by: Derek Nola <[email protected]>
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggested changes to wording. We could probably use an example of how to specify references to ConfigMaps and Secrets.

docs/helm/helm.md Outdated Show resolved Hide resolved
docs/helm/helm.md Outdated Show resolved Hide resolved
dereknola and others added 3 commits September 5, 2023 13:40
Co-authored-by: Brad Davidson <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Co-authored-by: Brad Davidson <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
docs/helm/helm.md Outdated Show resolved Hide resolved
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about this, just to make it completely clear that its a bogus example

docs/helm/helm.md Outdated Show resolved Hide resolved
docs/helm/helm.md Outdated Show resolved Hide resolved
docs/helm/helm.md Outdated Show resolved Hide resolved
Signed-off-by: Derek Nola <[email protected]>
@dereknola dereknola merged commit d30c1e8 into k3s-io:main Sep 14, 2023
3 checks passed
@dereknola dereknola deleted the helm_comp_update branch October 20, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants