[release-1.30] Fix issue with loadbalancer failover to default server

[brandond]

Proposed Changes

The loadbalancer should only fail over to the default server if all other server have failed, and it should force fail-back to a preferred server as soon as one passes health checks.

The loadbalancer tests have been improved to ensure that this occurs.

Types of Changes

bugfix

Verification

See linked issue

Testing

yes

Linked Issues

• [Release-1.30] - Secondary etcd-only nodes do not reconnect to apiserver after outage if joined against an etcd-only node #11321

User-Facing Change

Further Comments

[codecov]

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 13.73%. Comparing base (4c74664) to head (2ad35a5).
Report is 5 commits behind head on release-1.30.

Files with missing lines	Patch %	Lines
pkg/agent/loadbalancer/servers.go	78.94%	4 Missing ⚠️
pkg/util/apierrors.go	0.00%	2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4c74664) and HEAD (2ad35a5). Click for more details.

HEAD has 18 uploads less than BASE

Flag	BASE (4c74664)	HEAD (2ad35a5)
inttests	11	0
e2etests	7	0

Additional details and impacted files

@@                Coverage Diff                @@
##           release-1.30   #11325       +/-   ##
=================================================
- Coverage         46.41%   13.73%   -32.69%     
=================================================
  Files               179      176        -3     
  Lines             18716    18655       -61     
=================================================
- Hits               8687     2562     -6125     
- Misses             8674    15796     +7122     
+ Partials           1355      297     -1058     

Flag	Coverage Δ
e2etests	?
inttests	?
unittests	13.73% <73.91%> (+0.17%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.