Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IPv6 in case is the first configured IP with dualstack #8581

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

rbrtbnfgl
Copy link
Contributor

Proposed Changes

Use always IPv6 when the first configured node-ip is IPv6 also in case of dualstack.
This fix also will always use the configured node-ip on kubelet to address rancher/rke2#4759
In case of dualstack node-ip it adds CloudDualStackNodeIPs=true as feature-gates configuration to fix #6023 from k8s 1.27 version and it doesn't require to add node-ip=0.0.0.0 within the kubelet args.
The PR also fix #8467 (comment) showing the IPv6 when listing pods.

Types of Changes

Verification

Testing

Linked Issues

#8467

User-Facing Change


Further Comments

@rbrtbnfgl rbrtbnfgl requested a review from a team as a code owner October 10, 2023 10:58
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ced25af) 44.73% compared to head (4925d04) 50.64%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8581      +/-   ##
==========================================
+ Coverage   44.73%   50.64%   +5.91%     
==========================================
  Files         140      144       +4     
  Lines       14738    14966     +228     
==========================================
+ Hits         6593     7580     +987     
+ Misses       7031     6173     -858     
- Partials     1114     1213      +99     
Flag Coverage Δ
e2etests 48.30% <54.54%> (?)
inttests 43.55% <50.00%> (-1.19%) ⬇️
unittests 19.55% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/agent/run.go 42.53% <100.00%> (-1.41%) ⬇️
pkg/cli/cmds/server.go 100.00% <ø> (ø)
pkg/agent/config/config.go 50.98% <0.00%> (+1.78%) ⬆️
pkg/daemons/agent/agent_linux.go 58.45% <50.00%> (-1.55%) ⬇️

... and 60 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dereknola dereknola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the kube-arg of 0.0.0.0 is no longer required, please modify the E2E dualstack test and remove those arguments with this PR.

@manuelbuil
Copy link
Contributor

Since CloudDualStackNodeIPs=true starts in 1.27, we won't be able to backport it to all branches. What if you split the PR into two commits? One without the CloudDualStackNodeIPs=true which can be backported to 1.25 and 1.26 and one with the CloudDualStackNodeIPs=true (or two PRs, whatever is easier to you)

@rbrtbnfgl
Copy link
Contributor Author

I already edited a different commit for 1.26 and 1.25. The fix is not working and kubelet is still prioritising the IPv4 as pod IP on those versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dual-stack not supporting <IPv6><IPv4>
5 participants