-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IPv6 in case is the first configured IP with dualstack #8581
Conversation
ad8eaee
to
b656c1a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8581 +/- ##
==========================================
+ Coverage 44.73% 50.64% +5.91%
==========================================
Files 140 144 +4
Lines 14738 14966 +228
==========================================
+ Hits 6593 7580 +987
+ Misses 7031 6173 -858
- Partials 1114 1213 +99
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the kube-arg of 0.0.0.0 is no longer required, please modify the E2E dualstack test and remove those arguments with this PR.
b656c1a
to
d88ff46
Compare
Signed-off-by: Roberto Bonafiglia <[email protected]>
d88ff46
to
4925d04
Compare
Since |
I already edited a different commit for 1.26 and 1.25. The fix is not working and kubelet is still prioritising the IPv4 as pod IP on those versions. |
Proposed Changes
Use always IPv6 when the first configured
node-ip
is IPv6 also in case of dualstack.This fix also will always use the configured
node-ip
on kubelet to address rancher/rke2#4759In case of dualstack
node-ip
it addsCloudDualStackNodeIPs=true
asfeature-gates
configuration to fix #6023 from k8s 1.27 version and it doesn't require to addnode-ip=0.0.0.0
within the kubelet args.The PR also fix #8467 (comment) showing the IPv6 when listing pods.
Types of Changes
Verification
Testing
Linked Issues
#8467
User-Facing Change
Further Comments