Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.28] Allow executors to define containerd and docker behavior #9254

Conversation

HarrisonWAffel
Copy link
Contributor

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

rancher/rke2#5292

User-Facing Change

Further Comments

@HarrisonWAffel HarrisonWAffel requested a review from a team as a code owner January 17, 2024 20:26
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (4724315) 45.52% compared to head (0f09a20) 44.85%.
Report is 17 commits behind head on release-1.28.

Files Patch % Lines
pkg/daemons/agent/agent.go 25.00% 9 Missing and 3 partials ⚠️
pkg/agent/run.go 60.00% 1 Missing and 1 partial ⚠️
pkg/daemons/executor/embed.go 50.00% 2 Missing ⚠️
pkg/daemons/executor/executor.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28    #9254      +/-   ##
================================================
- Coverage         45.52%   44.85%   -0.68%     
================================================
  Files               154      154              
  Lines             16497    16549      +52     
================================================
- Hits               7511     7423      -88     
- Misses             7764     7944     +180     
+ Partials           1222     1182      -40     
Flag Coverage Δ
inttests 42.36% <43.75%> (-0.81%) ⬇️
unittests 14.52% <0.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitorsavian vitorsavian merged commit a922a0e into k3s-io:release-1.28 Feb 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants