Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.26] Backports for 2024-02 release cycle #9464

Merged
merged 10 commits into from
Feb 10, 2024

Conversation

brandond and others added 10 commits February 9, 2024 23:47
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 4005600)
Signed-off-by: Brad Davidson <[email protected]>
The reconcile may run before the kubelet has created the node object; retry until it succeeds

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 82e3c32)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 6ec1926)
Signed-off-by: Brad Davidson <[email protected]>
Ref: rancher/plugins@v1.3.0-k3s1...v1.4.0-k3s2

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 77ba990)
Signed-off-by: Brad Davidson <[email protected]>
The nodes controller was reading from the configmaps cache, but doesn't add any handlers, so if no other controller added configmap handlers, the cache would remain empty.

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 888f866)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 8224a3a)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Oleg Matskiv <[email protected]>
(cherry picked from commit e3b237f)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Edgar Lee <[email protected]>
(cherry picked from commit 14c6c63)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Edgar Lee <[email protected]>
(cherry picked from commit 0ac4c6a)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit de82584)
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from a team as a code owner February 9, 2024 23:49
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (b5da7cf) 14.73% compared to head (6f0fecd) 14.72%.

Files Patch % Lines
pkg/etcd/etcd.go 35.71% 17 Missing and 1 partial ⚠️
pkg/rootless/mounts.go 0.00% 11 Missing ⚠️
pkg/etcd/snapshot.go 0.00% 6 Missing ⚠️
pkg/cluster/cluster.go 0.00% 5 Missing ⚠️
pkg/etcd/snapshot_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.26    #9464      +/-   ##
================================================
- Coverage         14.73%   14.72%   -0.01%     
================================================
  Files               115      115              
  Lines              8457     8475      +18     
================================================
+ Hits               1246     1248       +2     
- Misses             6961     6977      +16     
  Partials            250      250              
Flag Coverage Δ
unittests 14.72% <19.60%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 4379b27 into k3s-io:release-1.26 Feb 10, 2024
15 checks passed
@brandond brandond deleted the 2024-02-backports_release-1.26 branch June 6, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants