Add acpiIndex selector
#488
Conversation
Pull Request Test Coverage Report for Build 5159544610Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
ian-howell
force-pushed
the
dev/acpi-index-selector
branch
from
2facafd to
9f71e85
Compare
|
Fixed the merge conflicts. @Eoghan1232 @adrianchiris @SchSeba Gentle nudge to request reviews when you find time. Thanks in advance! |
ian-howell
force-pushed
the
dev/acpi-index-selector
branch
from
a27864d to
e171535
Compare
| @@ -382,6 +382,24 @@ func GetDriverName(pciAddr string) (string, error) { | |||
| return filepath.Base(driverInfo), nil | |||
| } | |||
|
|
|||
| // GetAcpiIndex returns the ACPI index attached to a pci device from its pci address | |||
| func GetAcpiIndex(pciAddr string) (string, error) { | |||
| acpiIndexLink := filepath.Join(sysBusPci, pciAddr, "acpi_index") | |||
There was a problem hiding this comment.
some questions on acpi index:
when will i have an acpi_index ?
do i need to boot using UEFI to have this index ?
do i need some special kernel cmdline flag to expose it ?
checked on baremetal machine an NVIDIA NIC, it did not have an acpi index so probably something is not enabled.
There was a problem hiding this comment.
I checked on my system with an Intel NIC, it did not have an acpi index, so I am guessing something in bios must be enabled.
There was a problem hiding this comment.
This is inside a virtual machine
There was a problem hiding this comment.
I'm not certain what actually causes a machine to get an acpi_index. As SchSheba pointed out, this is inside of a libvirt VM, (or more specifically for my case, a kubevirt VM using this field).
|
Is there anything left to do prior to merging this? |
|
@adrianchiris are you okay for this to be merged? |
|
lemme have a quick look |
No description provided.