Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency elazarl/goproxy #499

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

SalDaniele
Copy link
Contributor

This commit updates a number of dependencies, namely k8s.io/apimachinery, in order to remove the dependency on the outdated package github.com/elazarl/goproxy

Signed-off-by: Salvatore Daniele <[email protected]>
@SalDaniele
Copy link
Contributor Author

SalDaniele commented Aug 23, 2023

@wizhaoredhat @bn222 PTAL

@bn222
Copy link
Contributor

bn222 commented Aug 24, 2023

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5954792365

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.24%

Totals Coverage Status
Change from base Build 5809183422: 0.0%
Covered Lines: 1956
Relevant Lines: 2500

💛 - Coveralls

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SalDaniele
Copy link
Contributor Author

@zeeke Is it possible to merge this?

@zeeke
Copy link
Member

zeeke commented Aug 28, 2023

We need a green light from other maintainers:

@adrianchiris , @Eoghan1232 PTAL

Copy link
Collaborator

@Eoghan1232 Eoghan1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants