Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix push-manifest github action job for release #512

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Fix push-manifest github action job for release #512

merged 1 commit into from
Nov 26, 2023

Conversation

adrianchiris
Copy link
Contributor

Add missing env variable

@adrianchiris
Fix push-manifest github action job for release
f0611f4 
Add missing env variable

Signed-off-by: adrianc <[email protected]>
@adrianchiris
Copy link
Contributor Author

@zeeke PTAL

@adrianchiris adrianchiris mentioned this pull request Nov 23, 2023
Closed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6971456085

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.628%
Totals Coverage Status
Change from base Build 6651326088: 0.0%
Covered Lines: 2017
Relevant Lines: 2667
💛 - Coveralls

zeeke
zeeke approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks for fixing this

@adrianchiris adrianchiris merged commit bc73859 into k8snetworkplumbingwg:master Nov 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeke zeeke zeeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrianchiris @coveralls @zeeke