Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restart the device plugin if NotifyRegistrationStatus returns failure #600

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liuyuan10
Copy link
Contributor

Today it only logs and stop the rpc server. The plugin hangs after that.

@coveralls
Copy link
Collaborator

coveralls commented Sep 24, 2024

Pull Request Test Coverage Report for Build 11023672725

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 75.26%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/resources/server.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/resources/server.go 1 80.9%
Totals Coverage Status
Change from base Build 10918054008: 0.0%
Covered Lines: 2102
Relevant Lines: 2793

💛 - Coveralls

Today it only logs and stop the rpc server. The plugin hangs after that.

Signed-off-by: Yuan Liu <[email protected]>
@liuyuan10
Copy link
Contributor Author

@adrianchiris I wonder if you can take a quick look of this PR? it should be a small fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants